search

billyvg / OverlayPlugin-themes

Different layouts for FFXIV ACT OverlayPlugin
74 stars 28 forks source link

Adding colors to SMN and RDM. #23

Closed trfunk closed 7 years ago

trfunk commented 7 years ago

Tried to stay as faithful as possible, icons worked out of the box. Did not remove misses or parry, since it can still occur. SAM colour is beige and RDM is light red: https://i.imgur.com/BjIlYoB.png.

christianallred commented 7 years ago

I'm fine with this pull but i am curious why the capital SAM and RDM, where every other class css is lowercase? is it coming through odd in the app?

trfunk commented 7 years ago

I tried it with lowercase and for some reason it did not work. Haven't figured out why so far.

christianallred commented 7 years ago

hrm that is odd. its all pure JS no frawework. i wil have to take a look at it when i get home.

christianallred commented 7 years ago

row.className = 'row ' + (combatant.Job !== '' ? combatant.Job.toLowerCase() : 'jobless') + (combatantName === "YOU" ? " you" : ""); this snippet of code shoudl be what is populating that bar class. so not sure why toLowerCase() is failing.