Testing returning error Cannot read property substring...

[bsides]

Hi guys,

I would like to develop a simple theme but I'm stuck on where to start here. I believe I was supposed to start from testing.html but it's throwing an error

Uncaught TypeError: Cannot read property 'substring' of undefined

Which maps to rdmty.js file line 247 that reads

DirectHitPct += parseFloat(data[x].DirectHitPct.substring(0, data[x].DirectHitPct.length - 1));

From my experience there is something wrong with DirectHitPct not being defined when it reaches that line. I could debug this but I thought maybe I could throw it here and see if anyone already fixed.

Anyway my real question would be what is the best way to start developing a theme? Which file to get into in the newer version of Overlay plugin?

Thanks in advance.

[christianallred]

This is a warning that I introduced on accident I need to update it. Rdmty.js is a compiled react file. It shouldn't be edited directly. The bigger question of where to start is really up to you I. How you would like to develop it. You could use pure js or just a about any framework it's totally up to you. At the end of the day overlay plugin simply outputs a browser with a global object that act passes updated values too. What you do with those values is up to you

Sent from my iPhone

On Aug 7, 2017, at 2:52 PM, Rafael Pereira notifications@github.com wrote:

Hi guys,

I would like to develop a simple theme but I'm stuck on where to start here. I believe I was supposed to start from testing.html but it's throwing an error

Uncaught TypeError: Cannot read property 'substring' of undefined Which maps to rdmty.js file line 247 that reads

DirectHitPct += parseFloat(data[x].DirectHitPct.substring(0, data[x].DirectHitPct.length - 1)); From my experience there is something wrong with DirectHitPct not being defined when it reaches that line. I could debug this but I thought maybe I could throw it here and see if anyone already fixed.

Anyway my real question would be what is the best way to start developing a theme? Which file to get into in the newer version of Overlay plugin?

Thanks in advance.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[christianallred]

Its a null check at the start of fights. I will fix it tonight or tomorrow

Sent from my iPhone

On Aug 7, 2017, at 2:52 PM, Rafael Pereira notifications@github.com wrote:

Hi guys,

I would like to develop a simple theme but I'm stuck on where to start here. I believe I was supposed to start from testing.html but it's throwing an error

Uncaught TypeError: Cannot read property 'substring' of undefined Which maps to rdmty.js file line 247 that reads

DirectHitPct += parseFloat(data[x].DirectHitPct.substring(0, data[x].DirectHitPct.length - 1)); From my experience there is something wrong with DirectHitPct not being defined when it reaches that line. I could debug this but I thought maybe I could throw it here and see if anyone already fixed.

Anyway my real question would be what is the best way to start developing a theme? Which file to get into in the newer version of Overlay plugin?

Thanks in advance.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[bsides]

Alright thanks @christianallred. Is there anything else you could point me to? I got the hang of the data already, just checking if there's anything else.