fixed brightness when using external screens

billziss-gh / EnergyBar

Supercharge your Mac's Touch Bar.

GNU General Public License v3.0

749 stars 34 forks source link

fixed brightness when using external screens #24

Open clemenstyp opened 5 years ago

clemenstyp commented 5 years ago

I fixed the brightness, so that is cycles through all displays and changes the build-in one. The last solution did not work, when you had a second screen attached, that you used a your main display.

billziss-gh commented 5 years ago

Thanks. I will take a look at this some time later in the week.

billziss-gh commented 5 years ago

In addition to my comments above your patch changes EnergyBar to control the builtin display instead of the main display.

I am not sure what the correct behavior is but why should the brightness slider control the brightness of the builtin display and not the main display?
What do the default brightness control in macOS do? Do they control the builtin display or the main one? I believe EnergyBar should do the same.

evanrobertson commented 5 years ago

@billziss-gh @clemenstyp The default touchbar behaviour appears to change the built in display for me when using an external monitor, at the same time however my external doesn't offer software brightness control.

It would be good if we had a setting at least that let EnergyBar change the built in diplays brightness rather than the main display.