search

billziss-gh / EnergyBar

Supercharge your Mac's Touch Bar.
GNU General Public License v3.0
749 stars 34 forks source link

Add 'Lock Screen' widget #29

Closed tresni closed 5 years ago

tresni commented 5 years ago

Touchbar widget that locks the screen.

billziss-gh commented 5 years ago

@tresni thank you for the PR. This looks great.

I will merge it in, but I am wondering if it would work better as a button or at least if the icon was a bit brighter. What do you think?

tresni commented 5 years ago

@billziss-gh I can't figure out why the icon is dulled.. I thought maybe the template image was not using RGB(0,0,0) or something tweaked on alpha, but that didn't appear to be the case. It could be a button vs just the icon, I just wanted to keep it small and like the look of just the lock, but I'm not tied to it ;-)

billziss-gh commented 5 years ago

I can't figure out why the icon is dulled

I think the reason is that we are using the lock as a template image. If we made the icon white and did not use it as a template image it will likely no longer appear dulled.

I am happy to keep it as a non-button as I do not have a strong preference either. I suggested that it should be a button for consistency with the other buttons/controls.