search

bilylee / SiamFC-TensorFlow

A TensorFlow implementation of the SiamFC tracker
MIT License
366 stars 112 forks source link

Add some comments in `get_crops` function #4

Closed sydney0zq closed 6 years ago

sydney0zq commented 6 years ago

As in my comments, I think get_crops may make others confused for:

  1. It is in infer_utils.py, but actually when we do inference process, it will not be called. The same questionable function is get_subwindow_avg, we call it in get_crops only
  2. The variable names although correspond with matlab version, but it really needs time to completely figure out what the function does if we are not familiar with this paper
bilylee commented 6 years ago

I admire your efforts and this project definitely can be improved in several aspects: documentation, unit test, etc. However, given limited time budget and relatively small user group, I will leave it as it is, for now.

sydney0zq commented 6 years ago

That’s all right. The current build works fine and code structure is readily comprehensible, except some syntactic sugar bringing extra cost. My PR just includes some personal and little exploration for anyone who maybe getting stuck as me. Thanks for your excellent and cohesive work!