In China, the location of the car shifts in HA when the device_tracker.xxx is updated

muxiachuixue commented 2 years ago

Describe the issue

When I restart HA or execute the following service, the gps location of the car in HA will shift to northwest:

service: homeassistant.update_entity
target:
  entity_id:
    - device_tracker.my_car

In #378, you fixed the coordinates shift. However, when the entity is updated, it seems that the conversion algorithm is executed again. If the homeassistant.update_entity service is called for 10 times, the coordinates of the car will shift 10 times far away from the correct location.

Expected behavior

When device_tracker.my_car is updated in HA, the location of the car will not shift.

Which Home Assistant version are you using?

core-2022.2.6

What was the last working version of Home Assistant Core?

No response

What is your region?

China

ConnectedDrive website

[X] I can still successfully login to the BMW ConnectedDrive website and the car status is available there.
[X] I have ConnectedDrive enabled for my vehicle.

Number of cars

[ ] I have 2 or more cars linked to the ConnectedDrive account.
[ ] I have a Mini vehicle linked to my account.

Output of bimmer_connected fingerprint

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

rikroe commented 2 years ago

Thanks for the report, the fix is easy but was also easy to miss (see #421).

muxiachuixue commented 2 years ago

Thanks for the report, the fix is easy but was also easy to miss (see #421).

Thanks. So when this new update will be available for HA? The 2022.3.0 version of HA has just been released, but I did not see the update of BMW Connected Drive to fix this bug.

rikroe commented 2 years ago

It is included, but only visible in the full changelog at https://www.home-assistant.io/changelogs/core-2022.2

Seems they had to split it off otherwise it would have been too long.

muxiachuixue commented 2 years ago

It is included, but only visible in the full changelog at https://www.home-assistant.io/changelogs/core-2022.2

Seems they had to split it off otherwise it would have been too long.

The 2022.3.0 version of HA fix this bug. Thanks.

github-actions[bot] commented 2 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

bimmerconnected / bimmer_connected