bimmerconnected / bimmer_connected

🚘 Library to query the status of your BMW or Mini from the ConnectedDrive portal
Apache License 2.0
365 stars 79 forks source link

Feature Request is_vehicle_active #523

Closed DatDraggy closed 1 year ago

DatDraggy commented 1 year ago

Hi, I love the bimmer connected integration. It's quite handy for automations and data history. Recently I tried to compose an automation that checks if I left any windows/lids open, but noticed that the is_vehicle_active state from bimmer_connected.vehicle.vehicle.MyBMWVehicle isn't implemented yet. Because of that I can only use the last_changed attribute of other states like mileage, which could get annoying the next time I'm in a traffic jam in summer. Lock state isn't a viable option either as my car auto-locks itself once you start driving. I've had a look through the code myself because I thought surely this isn't too hard to add but sadly I couldn't figure it out properly.

I hope that this'll be a part of a future bimmerconnected version 🙏

Thank you for all the work regardless

gerard33 commented 1 year ago

The is_vehicle_active function is always returning False at the moment. I believe that info was available in the past for some cars, but in the current API version that info is not available anymore.

Doublechecking with @rikroe.

rikroe commented 1 year ago

Unfortunately cannot give any more insights.

@kriscremers as you own a vehicle with the latest infotainment, are you able to get an fingerprint or HA diagnostic log while somebody is driving your vehicle so we can check?

gerard33 commented 1 year ago

I have made a fingerprint while driving with my car (iX3 from 2022) and that information is not available for me. Maybe something only the cars with the latest infotainment support indeed.

kriscremers commented 1 year ago

@rikroe I'm the only one driving the vehicle, so I need to figure out a way to gather the information while I drive. The fingerprint I have available for a supposedly inactive state doesn't list it (dated 2023-02-21), however. I'd presume this information would be in the json data regardless, but flagged FALSE.

rikroe commented 1 year ago

Sure, take your time and if it doesn't work out safely, don't do it! You might be able to get the diagnostic logs on the mobile app (android at least).

kriscremers commented 1 year ago

@rikroe I made a fingerprint on my way to work this morning, sadly it doesn't contain said information.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.