Add climatization status

rikroe commented 1 year ago

Proposed change

This PR adds (if available on vehicle):

climatization status (HEATING, COOLING, STANDBY, INACTIVE, UNKNOWN)
end time of climatization
True/False indicator if climatization is ON

Type of change

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (which adds functionality to this library)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue: #521

Checklist

[x] The code change is tested and works locally.
[x] Tests have been added to verify that the new code works.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5073b39) 100.00% compared to head (133bfe2) 100.00%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #527 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 17 18 +1 Lines 1410 1446 +36 ========================================= + Hits 1410 1446 +36 ``` | Flag | Coverage Δ | | |---|---|---| | 3.10 | `100.00% <100.00%> (ø)` | | | 3.11 | `100.00% <100.00%> (?)` | | | 3.7 | `100.00% <100.00%> (?)` | | | 3.8 | `100.00% <100.00%> (ø)` | | | 3.9 | `100.00% <100.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bimmerconnected#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/bimmerconnected/bimmer_connected/pull/527?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bimmerconnected) | Coverage Δ | | |---|---|---| | [bimmer\_connected/vehicle/climate.py](https://codecov.io/gh/bimmerconnected/bimmer_connected/pull/527?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bimmerconnected#diff-YmltbWVyX2Nvbm5lY3RlZC92ZWhpY2xlL2NsaW1hdGUucHk=) | `100.00% <100.00%> (ø)` | | | [bimmer\_connected/vehicle/vehicle.py](https://codecov.io/gh/bimmerconnected/bimmer_connected/pull/527?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bimmerconnected#diff-YmltbWVyX2Nvbm5lY3RlZC92ZWhpY2xlL3ZlaGljbGUucHk=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bimmerconnected). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bimmerconnected)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mannibis commented 1 year ago

Will this now make the Climate function 1 button (like the lock), instead of having a separate start and stop switch? I assume by reading the status of climatization we can now have a true single climate entity that will stay on after activating and turn off (or manually stopped), like a fan.

rikroe commented 1 year ago

Will this now make the Climate function 1 button (like the lock)

Yes, this is the plan. At least for cars that return the climate state. For others, we'll stay with the only one-shot buttons.

However the PR for HA is not yet open, so might take a little bit.

mannibis commented 1 year ago

So not sure it's me not doing something right but I don't see any new entities in the HA integration. Is the integration upgrade process automatic when updating HA? I'm on the 2023.5 release but it doesn't seem like the BMW integration is any different

rikroe commented 1 year ago

Thanks for the reminder - open quite a lot of PRs to HA so forgot to actually add one climate status.

Maybe I'll find some time next week to implement it. I'll update in the discussion.

bimmerconnected / bimmer_connected