bimmerconnected / bimmer_connected

🚘 Library to query the status of your BMW or Mini from the ConnectedDrive portal
Apache License 2.0
365 stars 79 forks source link

Add support for Python 3.12 #553

Closed cdce8p closed 1 year ago

cdce8p commented 1 year ago

Proposed change

Type of change

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (95cd1de) 100.00% compared to head (44001bc) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #553 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 18 18 Lines 1504 1504 ========================================= Hits 1504 1504 ``` | Flag | Coverage Δ | | |---|---|---| | 3.10 | `100.00% <100.00%> (ø)` | | | 3.11 | `100.00% <100.00%> (ø)` | | | 3.12 | `100.00% <100.00%> (?)` | | | 3.7 | `100.00% <100.00%> (ø)` | | | 3.8 | `100.00% <100.00%> (ø)` | | | 3.9 | `100.00% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bimmerconnected#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/bimmerconnected/bimmer_connected/pull/553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bimmerconnected) | Coverage Δ | | |---|---|---| | [bimmer\_connected/api/authentication.py](https://app.codecov.io/gh/bimmerconnected/bimmer_connected/pull/553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bimmerconnected#diff-YmltbWVyX2Nvbm5lY3RlZC9hcGkvYXV0aGVudGljYXRpb24ucHk=) | `100.00% <100.00%> (ø)` | | | [bimmer\_connected/api/utils.py](https://app.codecov.io/gh/bimmerconnected/bimmer_connected/pull/553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bimmerconnected#diff-YmltbWVyX2Nvbm5lY3RlZC9hcGkvdXRpbHMucHk=) | `100.00% <100.00%> (ø)` | | | [bimmer\_connected/vehicle/location.py](https://app.codecov.io/gh/bimmerconnected/bimmer_connected/pull/553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bimmerconnected#diff-YmltbWVyX2Nvbm5lY3RlZC92ZWhpY2xlL2xvY2F0aW9uLnB5) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cdce8p commented 1 year ago

I was just yesterday thinking about removing official Python 3.7 support and all the deprecation warnings we have in our code.

Removal of Python 3.7 would require the separate importlib-metadata anymore, however I'll proably won't make it until the next weekend.

Should I update the PR to remove importlib-metadata? I think it should be easy enough to do even after this PR is merged.

rikroe commented 1 year ago

No need - I'll merge your PR first and then remove Python 3.7. Just want to make sure I've got some time and can do all at once.