Closed rikroe closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
5d78330
) 100.00% compared to head (6ce2869
) 100.00%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
A hint (from my fast test)
in the function "get_vehicle_image", headers must now also include the entry "bmw-app-vehicle-type" with the value "connected"
return values from the server was
"statusCode":400,"error":"Bad Request","message":["bmw-app-vehicle-type should not be null or undefined","bmw-app-vehicle-type must be one of: connected, demo, non-connected, predelivery"]
i din't use python, so i can't create an pull-request
i think it should bei
headers={"bmw-vin": self.vin, "accept": "image/png", "bmw-app-vehicle-type": "connected"},
Many thanks for the quick feedback! Adjusted this in #591 as well, as this is based on it.
Proposed change
Refactor the way we get vehicle data a bit, hopefully to make it clearer and less of an effort to add additional endpoints.
Based on #591 so that should be merged first.
Type of change
Additional information
Checklist