bimmerconnected / bimmer_connected

🚘 Library to query the status of your BMW or Mini from the ConnectedDrive portal
Apache License 2.0
373 stars 81 forks source link

Move extras_require to setup.cfg #601

Closed cdce8p closed 8 months ago

cdce8p commented 8 months ago

Proposed change

Saw a warning from pip when I tried to install bimmer-connected[china]==0.14.6 (for Home Assistant).

WARNING: bimmer-connected 0.14.6 does not provide the extra 'china'

Turns out pbr has an open bug where extras_require inside setup.py are ignored. This changed moves them to setup.cfg so it is included in the sdist / wheel metadata. This might fix #588.

https://bugs.launchpad.net/pbr/+bug/1931705 https://setuptools.pypa.io/en/latest/userguide/dependency_management.html#optional-dependencies

Type of change

Additional information

Checklist

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (bd4b15a) to head (e832b8c). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #601 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 17 17 Lines 1428 1428 ========================================= Hits 1428 1428 ``` | [Flag](https://app.codecov.io/gh/bimmerconnected/bimmer_connected/pull/601/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bimmerconnected) | Coverage Δ | | |---|---|---| | [3.10](https://app.codecov.io/gh/bimmerconnected/bimmer_connected/pull/601/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bimmerconnected) | `100.00% <ø> (ø)` | | | [3.11](https://app.codecov.io/gh/bimmerconnected/bimmer_connected/pull/601/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bimmerconnected) | `100.00% <ø> (ø)` | | | [3.12](https://app.codecov.io/gh/bimmerconnected/bimmer_connected/pull/601/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bimmerconnected) | `100.00% <ø> (ø)` | | | [3.8](https://app.codecov.io/gh/bimmerconnected/bimmer_connected/pull/601/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bimmerconnected) | `100.00% <ø> (ø)` | | | [3.9](https://app.codecov.io/gh/bimmerconnected/bimmer_connected/pull/601/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bimmerconnected) | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bimmerconnected#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rikroe commented 8 months ago

Thanks, didn't see that before.

I think it makes sense to also move the install_requires to setup.cfg, so there is only one place where it is defined. Would you agree?

cdce8p commented 8 months ago

I think it makes sense to also move the install_requires to setup.cfg, so there is only one place where it is defined. Would you agree?

Done!