Closed cdce8p closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
bd4b15a
) to head (e832b8c
). Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks, didn't see that before.
I think it makes sense to also move the install_requires
to setup.cfg
, so there is only one place where it is defined. Would you agree?
I think it makes sense to also move the
install_requires
tosetup.cfg
, so there is only one place where it is defined. Would you agree?
Done!
Proposed change
Saw a warning from pip when I tried to install
bimmer-connected[china]==0.14.6
(for Home Assistant).Turns out
pbr
has an open bug whereextras_require
insidesetup.py
are ignored. This changed moves them tosetup.cfg
so it is included in the sdist / wheel metadata. This might fix #588.https://bugs.launchpad.net/pbr/+bug/1931705 https://setuptools.pypa.io/en/latest/userguide/dependency_management.html#optional-dependencies
Type of change
Additional information
Checklist