search

bimmerconnected / bimmer_connected

🚘 Library to query the status of your BMW or Mini from the ConnectedDrive portal
Apache License 2.0
379 stars 81 forks source link

CLI requires lat/lon in params for charging #644

Closed rikroe closed 2 months ago

rikroe commented 3 months ago

@rikroe I ran into a problem with 16.1 CLI version, when trying to start/stop charging:

bimmerconnected charge USERNAME PASSWORD rest_of_world VIN start

Traceback (most recent call last): File "C:\Users\jeter\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 196, in _run_module_as_main return _run_code(code, main_globals, None, File "C:\Users\jeter\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 86, in _run_code exec(code, run_globals) File "C:\Users\jeter\AppData\Local\Programs\Python\Python310\Scripts\bimmerconnected.exe\__main__.py", line 7, in <module> File "C:\Users\jeter\AppData\Local\Programs\Python\Python310\lib\site-packages\bimmer_connected\cli.py", line 334, in main if args.lat and args.lng: AttributeError: 'Namespace' object has no attribute 'lat'

I guess you need something like: if args.lat.exists() in line 334 in cli.py?

_Originally posted by @jeterke in https://github.com/bimmerconnected/bimmer_connected/discussions/627#discussioncomment-10214331_

Issue after refactoring CLI. Testing/parsing lat and lon only needs to be done for specific parameters.