bimmerconnected / ha_custom_component

Home Assistant Custom Component of BMW Connected Drive
33 stars 13 forks source link

Timestamp wrong #1

Closed tungmeister closed 4 years ago

tungmeister commented 4 years ago

Hi, I've tested today. There's no errors and the messages get delivered however the time shown is an hour behind and there's no actual notification of the message having arrived on the idrive (though this might be because it thinks it's an hour old?)

gerard33 commented 4 years ago

Thanks for testing. In the meanwhile we have released a new version where the notify service must be used for message and POI. So there are no bmw_connected_drive.send_message and bmw_connected_drive.send_poi anymore. See the readme file for extra info.

We are not finished yet, but maybe you can already test this?

And the timestamp shown is not from when the message is sent, but when the message is received in the car. I do see new messages have arrived, see the picture below. You don't have that info?

cc @rikroe

example_0

tungmeister commented 4 years ago

I'll test again in an hour or so. No I didn't get the message indicator or message count, I could only see that I'd got a message after going into connected drive messages.

gerard33 commented 4 years ago

I just did some tests an hour ago and didn't get that screen as well, though no messages either. So maybe something wrong with the BMW services or something with the latest version :see_no_evil:

But with the version you used for testing earlier, I did get the screen as shown on the photo.

tungmeister commented 4 years ago

Just tested again. The message was delivered but there was no notification. The time is definitely showing 1 hour behind still which is strange if that stamp is only generated when the message is received. IMG_20200331_213404

gerard33 commented 4 years ago

In which timezone are you? Maybe an UTC difference?

tungmeister commented 4 years ago

I'm in the UK so UTC + 1 which is maybe causing it, though that would be a strange limitation on BMWs part.

gerard33 commented 4 years ago

As you can see in my photos in the readme file, the times on the display and for the message are the same (1 minute difference). And I am in The Netherlands, so UTC+2 with the summer time now. So that's not causing the issue I guess.

tungmeister commented 4 years ago

It will be a non issue if noficatons are shown on the main screen, I'm just hoping it's just one of the many issues that the BMW servers have. I'll have another play tomorrow and test if a notification appears when I send a POI from the connected drive app.

gerard33 commented 4 years ago

Yeah, notifications should appear indeed. And also good to see which time is shown when you send a POI from the app.

rikroe commented 4 years ago

@tungmeister if you're trying tomorrow, please refresh the component. I've pushed some changes (multiple accounts/vehicles supported, POI attributes for display in the car)

tungmeister commented 4 years ago

@rikroe yeah I'll update the component before testing. I might do it later on tonight depending on how much wine I drink!

gerard33 commented 4 years ago

And some more minor changes to the component -> https://github.com/bimmerconnected/ha_custom_component/commit/5e8dd32b7d3586dc1ffd0ca6684216b7c8496bbe

Please use this version for further testing.

gerard33 commented 4 years ago

Messages have arrived in my car, also visible as new messages.

Timestamps are the times on which they arrive in my car, so no time differences.

tungmeister commented 4 years ago

Just to update you, I've tested again this evening and I still don't get notified of the message and the time stamp is still an hour out. I experienced the same issues with a POI sent from the app so I'm guessing it's something on my idrive that's causing it. I'll check coding tomorrow and report back.

gerard33 commented 4 years ago

Thanks for the update. We have released an update of the library v0.7.5 and some minor updates to notify.py. The latest versions of the files are in this repo. Please use this version for further testing.

Good to see the app gives you the same issues, then we know the bimmer_connected library works as expected.

I did some more tests with the latest version with my car and I receive the messages and POIs as earlier, so available in the notification overview and with the time they arrived in the car. In the meanwhile we have made a PR for HA.

gerard33 commented 4 years ago

The PR with the notify service is available in HA 0.109. Thanks for the testing.