bimspot / xeokit-react

Integratation of the xeokit viewer into a React application.
32 stars 22 forks source link

Import order bug #8

Closed barnabasmolnar closed 5 years ago

barnabasmolnar commented 5 years ago

In Viewers.js, the makeViewer import needs to come before the loader plugin imports, otherwise the component will fail with the following error:

Cannot access 'Component' before initialization

I've run into this issue during development and actually saved the file with the modules imported in the correct oder. It seems, however, that our ESLint config overwrites and reorders the imports when run.

This should be a relatively simple fix, just need to disable the import/order rule for this file/line.