search

bin-y / standard-ecies

Standard ECIES implemention for NodeJS based on crypto.ECDH with no other dependencies.
Creative Commons Zero v1.0 Universal
8 stars 2 forks source link

What are s1 and s2 for? #5

Open dko-slapdash opened 3 years ago

dko-slapdash commented 3 years ago

I mean, I see in the code how are they used, and also see the algorithm in Wikipedia. I wonder though, why may we need s1 and s2 being non-null, what benefit does their presence carry?..

It looks like in some cases (e.g. when the encrypted message is not sent over the wire to someone, but instead is stored locally and is encrypted just for privacy/security reasons), making s1+s2 process optional (and removing the tag suffix from the message) may free up some CPU resources.

bin-y commented 3 years ago

Yes, lots of performance optimizations could be made to current implementation. I was just trying to make the code simple because I believe the performance cost of those parts would be very small compared to ecdh calculations. What is your use case? Is that very performance-critical?

dko-slapdash commented 3 years ago

My usecase is encryption of the users’ data before writing it to some storage. The ciphertext is not transmitted over a public network, so there is no need for authentication.

bin-y commented 3 years ago

What about doing encryption on client side or simply using a symmetric block cipher? The first choice resulting an end-to-end encryption and the second one is better than ecies for streaming and reading from random offsets.