search

binSaed / flutter_cached_pdfview

Enhanced PDF view for Flutter.
https://pub.dev/packages/flutter_cached_pdfview
MIT License
121 stars 70 forks source link

Please review the class DownloadIndicator. #4

Closed Romavic closed 4 years ago

Romavic commented 4 years ago

In the DownloadIndicator class, if Text ('Downloading ...') appears, you should have the programmer's option to write whatever he wants in place of "Downloading".

So Text ('Downloading ...'), it should just be a Widget, which for anyone who wants to use the library should, put whatever he wants, while downloading the pdf ...

It may be the case that in place of Text ('Downloading ...'), I want to put a Gif ... or something else ...

Do you understand what I want?

binSaed commented 4 years ago

Hi @Romavic

thanks, for comments that helped me less than 1 hour I will push new code

Screen Recording 2020-07-30 at 3 21 32 PM

binSaed commented 4 years ago

take a look now https://github.com/AbdOoSaed/flutter_cached_pdfview#with-placeholder-until-pdffile-download-and-errorwidget-if-there-are-problem

Romavic commented 4 years ago

@AbdOoSaed It's better now ... Thanks for taking my suggestion into consideration.