search

binance-exchange / binacpp

Binance C++ library
MIT License
209 stars 108 forks source link

Fixes #20

Closed tensaix2j closed 6 years ago

tensaix2j commented 6 years ago

+Fixed seg_fault due to to_string +Fixed some makefile issues +Added license file

alexanderkoumis commented 6 years ago

Hi, I would argue that the to_string segfault is something environmental. I would highly suggest not using the ostringstream hack as this would lead to a performance hit. I have removed this hack in my latest merge request on the binance-exchange repository as it was causing compilation issues for multiple users due to the usage of using namespace std (which I would also advise against due to this issue).