binance-exchange / binance-java-api

binance-java-api is a lightweight Java library for the Binance API, supporting synchronous and asynchronous requests, as well as event streaming using WebSockets.
MIT License
837 stars 627 forks source link

Request: Mvn Repository #3

Open mwong56 opened 6 years ago

mwong56 commented 6 years ago

Can we get this added to maven repository?

joaopsilva commented 6 years ago

That was indeed in the plans, I will look into putting the library available from Maven Central in the next few days.

mwong56 commented 6 years ago

Awesome! I've been using this for now https://jitpack.io/#binance-exchange/binance-java-api

joaopsilva commented 6 years ago

JitPack is a great alternative indeed. In thea meantime, I have created a ticket with Sonatype (https://issues.sonatype.org/browse/OSSRH-36611), and if they are able to host the binaries, I will then synchronise them to Maven Central.

aparsons commented 6 years ago

+1 to getting this done

guitcastro commented 6 years ago

+1

klaszlo8207 commented 6 years ago

+1

yiqinghe commented 6 years ago

+1

klaszlo8207 commented 6 years ago

The jitpack url is working like a charm. I am using with gradle and android with full of luck:)

mehmetcansimsek commented 6 years ago

+1

volodymyr-shulga commented 6 years ago

+1

big-andy-coates commented 6 years ago

+1

zagorulkinde commented 6 years ago

+1

pako-g commented 6 years ago

+1

mustii82 commented 6 years ago

Still not available please upload it and make a jar version to easy import this Library

naeem-github commented 6 years ago

Please do this ASAP

vladimirus commented 6 years ago

in the meantime https://jitpack.io/ is quite good

       <repositories>
        <repository>
            <id>jitpack.io</id>
            <url>https://jitpack.io</url>
        </repository>
    </repositories>
       <dependency>
        <groupId>com.github.binance-exchange</groupId>
        <artifactId>binance-java-api</artifactId>
        <version>master-SNAPSHOT</version>
    </dependency>
big-andy-coates commented 6 years ago

Any update on this @joaopsilva?

afaslan commented 6 years ago

+1

tach1685 commented 6 years ago

+1

carvalho2707 commented 6 years ago

+1

tadaskrisciunas commented 6 years ago

+1

arild commented 6 years ago

+1

yaserhadi commented 6 years ago

+1

noonhub commented 5 years ago

The README seems to claim this is in Maven but a search only shows other libraries and a fork. ¯_(ツ)_/¯

tach1685 commented 5 years ago

Hi joaopsilva, Any news on where this issue is on the roadmap?

malkusch commented 5 years ago

@noonhub No it doesn't:

Install library into your Maven's local repository by running mvn install

wrone commented 5 years ago

+1

adcar commented 5 years ago

+1

qingyang-id commented 5 years ago

+1

antonvalletas commented 5 years ago

+1

mutellipiqbal commented 5 years ago

Maven Pom file could not find dependency version. version fualt

guicastrofer commented 5 years ago

+1 I have the same problem on my pom.xml, mentioned above.

joaovitormarques commented 5 years ago

Hello @joaopsilva , any news on this?

aparsons commented 5 years ago

I ran into a problem where my dependency was cached and the API calls were broken. Adding -SNAPSHOT to the dependency version will ensure you're using the latest version from jitpack.

repositories {
  maven { url "https://jitpack.io" }
}

dependencies {
  implementation 'com.github.binance-exchange:binance-java-api:master-SNAPSHOT'
}

On a side note, @joaopsilva please fix this. It's easy to do!

freekode commented 3 years ago

3 years and still open?

rotilho commented 3 years ago

Any progress on it? It should be a simple task.

chinnaxs commented 3 years ago

Also in favor of getting this to the maven repo

omerg commented 3 years ago

I've forked the project and then published to Maven Central Repository. Here is the dependency information:

<dependency>
  <groupId>tr.com.lucidcode</groupId>
  <artifactId>binance-api-client</artifactId>
  <version>1.0.0</version>
</dependency>
carlspring commented 3 years ago

Any updates on making this available from Maven Central?

adkr commented 3 years ago

Shame... Almost 4 years and this issue is still opened. That's really bad from technical, public relations and brand perspective.

infinic commented 2 years ago

+1

kwladyka commented 2 years ago

Any rationale why the library is not in mvn?

Edit: I didn't check it yet, but it looks like the https://github.com/binance/binance-connector-java it the right one.

carlspring commented 2 years ago

@kwladyka ,

Yes, the rationale is perfectly clear -- this project has been dead for a long while.

kwladyka commented 2 years ago

The project lucks of "deprecated" word in readme.md or should be archived in github. It is not obvious in first steps with Binance API.

carlspring commented 2 years ago

@kwladyka : If you check the commit history, you'll see that there has been no real activity on the project since it won the bounty for a Java implementation of a library for Binance. I don't think that the original author cares about further developing this. You can easily arrive to the same conclusion, if you have a look at the number of pull requests which have been made by various contributors and have not been reviewed, or merged.

kwladyka commented 2 years ago

I know. Just I am saying it is not friendly approach for developers :)

carlspring commented 2 years ago

@kwladyka : I agree, :)

joaopsilva commented 2 years ago

Hi @kwladyka , @carlspring , I did try to have the project on Maven right from the start, but since the groupId was set to com.binance.api, it needed the approval from someone at Binance (i.e. an email sent from "@binance.com"), and even though I requested it, the email was never sent. So moving forward the groupId would need to be renamed, or we would need to press Binance again.

Another issue is given the sensitivity of this API, and how it can have full access to your account for trading purposes, it's usually recommended to run a local audited copy instead of just blindly trusting a binary from Maven, but ultimately that depends on the trust-level of the developer, and I agree there should be an option.

Finally, I have been busy with multiple other projects since I released this API, and I no longer have time to actively maintain it, so I would happily accept new developers to take over; in case you are interested, please let me know, I will open an issue soon about it.