search

binance-exchange / binance-java-api

binance-java-api is a lightweight Java library for the Binance API, supporting synchronous and asynchronous requests, as well as event streaming using WebSockets.
MIT License
834 stars 627 forks source link

Update wallet endpoints #397

Open rezazadeh93 opened 3 years ago

rezazadeh93 commented 3 years ago

Updated WAPI endpoints to SAPI endpoints

Added all arguments that are supported by binance to these methods:

rezazadeh93 commented 3 years ago

if this pull request helped you, I'll be pleased to give me your feedback.

OfficialVreesie commented 3 years ago

Using the code I get an error when I don't have any deposits in the result. I get the following result from binance: [], but in my java code I get this error: 

com.binance.api.client.exception.BinanceApiException: com.fasterxml.jackson.databind.exc.MismatchedInputException: Cannot deserialize value of type com.binance.api.client.domain.account.DepositHistory from Array value (token JsonToken.START_ARRAY)
 at [Source: (okhttp3.ResponseBody$BomAwareReader); line: 1, column: 1]

What can I change to prevent casting to DepositHistorywhen there is no result?

rezazadeh93 commented 3 years ago

@PanderBoy18 pushed new commits, I hope the bug is fixed

OfficialVreesie commented 3 years ago

Yesss!!!! This fixed the bug. Great work!

TheLeBot commented 2 years ago

Great! Works for me too! Thanks!

ravesteijnd commented 2 years ago

I continued on this because I ran into the issue of having 0 as default instead of null in the requests. @rezazadeh93 see https://github.com/rezazadeh93/binance-java-api/pull/2.

strazdinsg commented 2 years ago

Is anyone maintaining this repository? It seems that old pull requests are never merged.

ravesteijnd commented 2 years ago

Is anyone maintaining this repository? It seems that old pull requests are never merged.

See https://github.com/binance-exchange/binance-java-api/issues/421