binance-exchange / binance-java-api

binance-java-api is a lightweight Java library for the Binance API, supporting synchronous and asynchronous requests, as well as event streaming using WebSockets.
MIT License
834 stars 627 forks source link

TRAILING_DELTA missing in FilterType #424

Open TheLeBot opened 2 years ago

TheLeBot commented 2 years ago

Since today 07.04.2022 the API for getting ExchangeInfo produces an exception because Binance added a new FilterType "TRAILING_DELTA" which is not a part of the enum FilterType in current Java-API. The only way to fix it is to extend FilterType with this value.

mehc77 commented 2 years ago

It doesn't work adding only that value in the enum..

TheLeBot commented 2 years ago

@mehc77 i only added TRAILING_DELTA to the enum and then it worked for me. Did you do something else except my solution?

mehc77 commented 2 years ago

@TheLeBot i have tried to update the enum in my api and getFilterType keeps giving an error, so I had to skip the search for lot_size to keep it working. I'll look into why just adding in the enum doesn't work, I also thought that would suffice..

TheLeBot commented 2 years ago

@mehc77 Which kind of error do you get? I think you better attach the changed class for your program. Probably it does not use your changes somehow. It worked promtely for me as I added TRAILING_DELTA.

selamiwork commented 2 years ago

Only added TRAILING_DELTA to the enum and then it worked for me. Like the following ;

public enum FilterType { // Symbol PRICE_FILTER, LOT_SIZE, MIN_NOTIONAL, MAX_NUM_ORDERS, MAX_ALGO_ORDERS, MAX_NUM_ALGO_ORDERS, ICEBERG_PARTS, PERCENT_PRICE, MARKET_LOT_SIZE, MAX_NUM_ICEBERG_ORDERS, MAX_POSITION, TRAILING_DELTA,

// Exchange EXCHANGE_MAX_NUM_ORDERS, EXCHANGE_MAX_ALGO_ORDERS }

GitDani3l commented 2 years ago

Only added TRAILING_DELTA to the enum and then it worked for me. Like the following ;

public enum FilterType { // Symbol PRICE_FILTER, LOT_SIZE, MIN_NOTIONAL, MAX_NUM_ORDERS, MAX_ALGO_ORDERS, MAX_NUM_ALGO_ORDERS, ICEBERG_PARTS, PERCENT_PRICE, MARKET_LOT_SIZE, MAX_NUM_ICEBERG_ORDERS, MAX_POSITION, TRAILING_DELTA,

// Exchange EXCHANGE_MAX_NUM_ORDERS, EXCHANGE_MAX_ALGO_ORDERS }

Thank you so much!

meliksah commented 2 years ago

https://github.com/binance-exchange/binance-java-api/pull/425

TheLeBot commented 2 years ago

Those using OCO orders should probably have a look at this: https://github.com/binance-exchange/binance-java-api/pull/262/files/0f6856748cce6e011046c10732f5dccaac0352a1..e278acddb9c9cbbd5b7db9c49cb2497de7e35a48

FilterType for TRAILING_DELTA has some attributes, which should be added into the API declaration!

Eldenayri commented 1 year ago

You have to add "PERCENT_PRICE_BY_SIDE" also guys. it's new.