search

binance / binance-api-postman

Postman collection for Binance Public API, including spot, margin, futures, etc.
MIT License
1.34k stars 893 forks source link

Added 'SPOT' to type on Daily Account Snapshot #177

Closed victorp13 closed 2 years ago

victorp13 commented 2 years ago

Second attempt at creating this PR: Sorry, the previous commit had way too many changes! Please read below my explanation why I think "SPOT" should be provided as a default value for the type parameter on accountSnapshot. This is due to a bug in Postman.

Since the Wallet\Daily Account Snapshot does not have a value set for "type=", it can end up being confusing for new users of your collection. One has to read the documentation to find out that setting a value for "type=" is mandatory.

In addition, I also encountered oddities with the Postman UI that lead to unexpected "Signature for this request is not valid." errors when manually setting the "type=" value manually in the URL entry field:

ss

As you can see above, the "type" parameter will be pushed to the bottom of the Params list, leading to the signature not being calculated correctly. This is because Postman does not send the parameters in order of the URL entry box, but in order of the Params list.

bnbot commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: victorp13

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/binance/binance-api-postman/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
2pd commented 2 years ago

This PR is adding a default value to the type parameter. LGTM. We will merge into next release branch later.

2pd commented 2 years ago

Thank you