search

binance / binance-futures-connector-python

MIT License
803 stars 228 forks source link

Websocket connection exceptions are not handled by the user neither the on_error callback is called #173

Open malvanos opened 6 months ago

malvanos commented 6 months ago

Websocket connection exceptions are not handled by the user neither the on_error callback is called. It seems that there is a pull request for that #158. However, I believe the pull request for the Spot is better: https://github.com/binance/binance-connector-python/pull/274 compared with #158.

Expected behaviour Websocket connection errors should be handled by the on_error callback.

Actual behaviour The exception is raised inside the thread managing the websocket connection.

Steps to reproduce When closing the connection with any tool it will make the read to throw an exception.

Drake1804 commented 6 months ago

Got the same issue

xuanronaldo commented 1 month ago

Good job, Dude. I don't understand why this PR hasn't been merged yet.