binance / binance-websocket-examples

Example code in Nodejs that demonstrate how to subscribe to Binance Websocket server.
MIT License
154 stars 52 forks source link

Bugs fix : Commands can't be executed because apiSecret is loaded incorrectly #12

Closed KeeUka closed 3 years ago

KeeUka commented 3 years ago

The project contains multiple typos that cause confusions to other developers:

In README.md the document specifies that an environemnt variable 'APISECRET' needs to be passed in.

However the code actually reads the variable 'APISECET' (without R) which is a typo. The consequence is that we cannot run the commands specified within the documentation.

Moreover the error is misleading. Once the apiSecret is not found, the exception 'API key is missing' is thrown. 'API secret is missing' should be thrown instead.

Fixes: