search

binarly-io / fwhunt-scan

Tools for analyzing UEFI firmware and checking UEFI modules with FwHunt rules
GNU General Public License v3.0
210 stars 30 forks source link

Regression after adding TE support #20

Closed hughsie closed 3 years ago

hughsie commented 3 years ago

Commit e6d1c68 regressed mypy, and there looks to be at least one actual bug:

./env/bin/mypy uefi_r2
uefi_r2/uefi_te.py:23: error: Call to untyped function "TerseExecutableError" in typed context
uefi_r2/uefi_te.py:31: error: Call to untyped function "TerseExecutableError" in typed context
uefi_r2/uefi_te.py:33: error: Incompatible types in assignment (expression has type "None", variable has type "int")
uefi_r2/uefi_te.py:34: error: Incompatible types in assignment (expression has type "None", variable has type "int")
uefi_r2/uefi_te.py:35: error: Incompatible types in assignment (expression has type "None", variable has type "int")
uefi_r2/uefi_te.py:36: error: Incompatible types in assignment (expression has type "None", variable has type "int")
uefi_r2/uefi_te.py:37: error: Incompatible types in assignment (expression has type "None", variable has type "int")
uefi_r2/uefi_te.py:38: error: Incompatible types in assignment (expression has type "None", variable has type "int")
uefi_r2/uefi_te.py:39: error: Incompatible types in assignment (expression has type "None", variable has type "int")
uefi_r2/uefi_te.py:60: error: Incompatible return value type (got "str", expected "int")
yeggor commented 3 years ago

Hi, thanks. The new version is here: https://pypi.org/project/uefi-r2/1.0.2/