search

binarly-io / fwhunt-scan

Tools for analyzing UEFI firmware and checking UEFI modules with FwHunt rules
GNU General Public License v3.0
212 stars 30 forks source link

fix rzpipe version to 0.1.0 #31

Closed flanfly closed 2 years ago

flanfly commented 2 years ago

Version 0.1.2 renamed the kw arg rizinhome to rizin_home.

hughsie commented 2 years ago

I think we want the later versions for the shm size fix. I think we probably ought to tell rizin about this API change and ask them what they want to do.

flanfly commented 2 years ago

Ah ok. I got it running by changing rizinhome to rizin_home in uefi_analyzer.py but I didn't investigate what else changed.

yeggor commented 2 years ago

@hughsie, I think it makes sense to set the version strictly equal to 0.1.2 (rzpipe == 0.1.2) and change the kw from rizinhome to rizin_home (@flanfly, thx for pointing this). As for shm size, things mentioned in https://github.com/binarly-io/uefi_r2/issues/29 still don't work as expected, but @XVilka is looking at it. The changes should not affect rzpipe, they will affect rizin itself.

yeggor commented 2 years ago

Put up the latest version and updated the kw: https://github.com/binarly-io/uefi_r2/commit/36af60c9e718cbfdd7a5a6d511f40afbcf42d839 Also rizin fixed shm buffer size issue: https://github.com/rizinorg/rizin/commit/ba5adf0045218b6c2eb0d06200c2ab49f306727c