search

binary-array-ld / net.binary_array_ld.bald

Java library for parsing, validating and managing binary array linked data files, e.g. HDF, netCDF.
Apache License 2.0
0 stars 3 forks source link

Aliases #23

Closed simonoakesepimorphics closed 3 years ago

simonoakesepimorphics commented 3 years ago

Fixes #12 Support attribute aliasing using alias graphs.

CMayNorris commented 3 years ago

Thanks for this Simon. Looks good! As the code gets larger I think future developers and I, as a reviewer, would benefit from some inline comments regarding which requirements are being met. In particular this would be useful in the test classes and around the model verification. Just a string including the lettered and numbered requirement would help identify the aims of each test or set of tests. Thank you

simonoakesepimorphics commented 3 years ago

Thanks for this Simon. Looks good! As the code gets larger I think future developers and I, as a reviewer, would benefit from some inline comments regarding which requirements are being met. In particular this would be useful in the test classes and around the model verification. Just a string including the lettered and numbered requirement would help identify the aims of each test or set of tests. Thank you

I've added some annotations referring to the requirements classes in the places where I think they're relevant. There are also a number of tests which test the "non-normative" part of the spec, which I haven't linked to a specific requirement. We could link those to the document fragments in the draft spec / spec project if appropriate but I don't know how permanent those are.

CMayNorris commented 3 years ago

Thanks for adding the requirement references, they are very helpful - Please continue to add these as new tests are added. Thanks also for the explanation and link to the spec regarding my question. This all looks good to me, I will approve and merge. Thanks for all the work!