search

binaryage / cljs-oops

ClojureScript macros for convenient native Javascript object access.
Other
351 stars 13 forks source link

oops + shadow-cljs 2.12 are not working together because of old GCL #26

Closed n2o closed 3 years ago

n2o commented 3 years ago

Heyho, thanks for this project, it makes javascript interop a lot better than using native functions!

I realized, that you are already replacing old GCL functions, and shadow-cljs released a new version today, which breaks using oops + latest shadow-cljs together. And I hope that you can release a new version soon :-)

Thanks for your work in this project!

darwin commented 3 years ago

Hi, I believe current master has fixes for recent GCL update. Could you test it with your project? I would then release a new cljs-oops version for convenience.

n2o commented 3 years ago

Hi, thanks for the quick reply. Yes, your latest commit in your master branch a2b48d59047c28decb0d6334e2debbf21848e29c works just fine.

Tested with latest versions of shadow-cljs and clojurescript:

binaryage/oops {:git/url "https://github.com/binaryage/cljs-oops"
                :sha "a2b48d59047c28decb0d6334e2debbf21848e29c"}
org.clojure/clojurescript {:mvn/version "1.10.844"}
thheller/shadow-cljs {:mvn/version "2.12.1"}
darwin commented 3 years ago

Thanks for confirmation. Fixed in v0.7.1.