search

binaryage / drydrop

Deploy static sites to App Engine by pushing to GitHub
http://drydrop.binaryage.com
Other
224 stars 32 forks source link

admin screen broken #2

Closed zzamboni closed 14 years ago

zzamboni commented 14 years ago

Hi again,

Before I broke my install with the issue I reported previously, I noticed the admin screen of my application was not being displayed properly - it looked as if the CSS files were not being loaded properly - I could see the contents, but without any styling.

I was wondering if maybe it's related to the GitHub move? Everything looked fine last week.

darwin commented 14 years ago

If you look at code for main request handler: http://github.com/darwin/drydrop/blob/master/dryapp/drydrop_handler.py#L275

Drydrop is first trying to resolve request using your site.yaml rules. If it is not successful, it runs system dispatch routine. Admin section is served using system dispatch, but you have to not override it by your site.

Or maybe there is some bug :-( Hard to say ...

darwin commented 14 years ago

I just tried drydropsample.appspot.com/admin

And I can confirm admin section is broken. I cannot even log in. Something was changed on Google side so it is broken now. I will probably get to fix during weekend.

darwin commented 14 years ago

Main site still works for me, so it is issue with something in admin section.

darwin commented 14 years ago

I gave it few minutes and the reason of broken admin screen is github beahvior.

If you request non-existent file in repo (for example http://github.com/darwin/web-app-theme/raw/master/abc/README.md) it returns with 200 OK and page saying "Repository temporarily unavailable". DryDrop just takes this as a real content.

That is also reason why admin screen is broken. Site.yaml dispatch is working and drydrop uses these buggy files in place of admin css and js files.

The reason why it works this way was enabling you to override admin.css and other files by your github repo if you want...

darwin commented 14 years ago

detect bogus status404 pages from github and treat them as real 404 pages (closed by b68d13fddd1380a6cd73d596124ede979e36e87f)

zzamboni commented 14 years ago

Hi - thanks. Unfortunately, this does not seem to have solved the problem for me. I still see the admin screen broken (I'm not getting the GitHub "repository unavailable" any more, though). Looking at the logs, I am not finding the "bogus 404" message you added in the latest patch.

Any ideas? Thanks for your help!

darwin commented 14 years ago

have you uploaded latest sources and cleared Resources via appengine console?

give me url which is failing for you, so I can investigate github's response

jacqueminv commented 14 years ago

Hi all,

Unfortunately the same issue for me here: http://scbcd-study-guide.appspot.com/ I have pulled the last version of drydrop...

Thanks

zzamboni commented 14 years ago

@darwin, do you know if there's an easy way to clear all the Resources? Deleting them a screenful at a time is quite painful, but I haven't found a better way...

zzamboni commented 14 years ago

Just to confirm that this issue has been fixed. Because the javascript files were apparently not properly cached, the "Flush resource cache" button in the admin screen didn't work, but I was able to manually flush the cache by going to /admin/flusher?command=go in my domain. Now everything works fine.

Thanks for all your help!