binaryage / totalterminal

Terminal.app plugin for quick access to terminal window (Quake-style)
http://totalterminal.binaryage.com
390 stars 36 forks source link

Custom Icon With TotalTerminal #99

Closed codeanpeace closed 10 years ago

codeanpeace commented 10 years ago

Custom Terminal icon gets replaced with default Terminal icon when TotalTerminal is launched. The selected preferences option "Keep the original Dock icon" somehow ignores the custom Terminal icon I substituted in for the default one.

darwin commented 10 years ago

Check in "Keep the original Dock icon" and restart both Terminal.app with TotalTerminal. There is no API to save original icon so I could swap it back.

codeanpeace commented 10 years ago

I understand that's what is supposed to happen, but for some odd reason it's not behaving as expected. When I launch TotalTerminal, the dock icon reverts back to the default icon regardless of whether I chose to "Keep the original Dock icon" or not - despite the fact that I have replaced the default icons for both Terminal and TotalTerminal with a custom one in the Content/Resources folder.

darwin commented 10 years ago

I have revisited the code and you are right. The default icon gets forced each time when TotalTerminal is launched.

st40611 commented 10 years ago

Also having this problem. I am guessing/hoping this will be fixed in the next release?

darwin commented 10 years ago

Fixed in v1.5: http://totalterminal.binaryage.com/#changelog