search

binaryai / sdk

Get results of binaryai.cn using our SDK
https://www.binaryai.cn/doc/
GNU General Public License v3.0
491 stars 75 forks source link

The binaryai cause my ida crash #84

Closed WinMin closed 4 years ago

WinMin commented 4 years ago

The IDA will crash after I drag a new binary to the window when there has already been an instance.

image

WinMin commented 4 years ago

image

DogeWatch commented 4 years ago

what's your IDA version and platform?

aundro commented 4 years ago

Hi, this is Arnaud Diederen, from Hex-Rays. We'll investigate this issue and get back to you, as it is possible that the culprit is IDA itself, not binaryai.

I'll keep you posted.

WinMin commented 4 years ago

what's your IDA version and platform?

IDA 7.5 windows

aundro commented 4 years ago

Hi again,

so, it turns out that the problem is in the binaryai plugin, but it didn't show until 7.5. Simply put, the plugin shouldn't return ida_loader.PLUGIN_OK, but rather ida_loader.PLUGIN_KEEP.

In fact, ida_loader.PLUGIN_OK is really meant for non-ida_loader.PLUGIN_FIX plugins. Plugins using ida_loader.PLUGIN_FIX should always return ida_loader.PLUGIN_KEEP (or ida_loader.PLUGIN_SKIP)

nforest commented 4 years ago

Hi again,

so, it turns out that the problem is in the binaryai plugin, but it didn't show until 7.5. Simply put, the plugin shouldn't return ida_loader.PLUGIN_OK, but rather ida_loader.PLUGIN_KEEP.

In fact, ida_loader.PLUGIN_OK is really meant for non-ida_loader.PLUGIN_FIX plugins. Plugins using ida_loader.PLUGIN_FIX should always return ida_loader.PLUGIN_KEEP (or ida_loader.PLUGIN_SKIP)

Great, thanks for your professional investigation. I can fix it later, or you're welcome to fork and pull a request.

aundro commented 4 years ago

I think it's easier (as in: less noise) if I just let you handle it.

nforest commented 4 years ago

I think it's easier (as in: less noise) if I just let you handle it.

sure, no problem.