binarybucks / homA

An extensible framework for the smart home
Eclipse Public License 1.0
137 stars 24 forks source link

Clicking SAVE after editing a device doesn't visually do anything #108

Closed jpmens closed 11 years ago

jpmens commented 11 years ago

Enhancement:

I click on a device, and that lets me edit, say, the device's name. Click on "SAVE", the value is saved, but there is no visual feedback.

Maybe it would suffice to just re-display the device, i.e. removing the "edit panel" for the device? Unsure of the terminology, I'll show a screenshot:

jmbp-624

After a click on SAVE I suggest going back to

jmbp-625

binarybucks commented 11 years ago

Yes, that's probably a good idea

binarybucks commented 11 years ago

Now navigating back to where the user came from (or going back to / if the url was accessed directly)

jpmens commented 11 years ago

Nice, thanks! Looks good this way.

jpmens commented 11 years ago

You don't want to hear this: It would be good if you added a similar behaviour to the "Settings" dialog -- same thing: it's hard to see if something has changed or not. sorry

binarybucks commented 11 years ago

I just waited for you to say that :D

jpmens commented 11 years ago

I'm just here to do quality-control on your stuff, that's all...

Works, thanks.