libproxy-0.4.6 is mixing CFLAGS with CXXFLAGS

[GoogleCodeExporter]

the packages uses CFLAGS in combination with g++:

[ 94%] Building C object 
bindings/perl/src/CMakeFiles/PLlibproxy.dir/Libproxy.c.o
cd 
/var/tmp/portage/net-libs/libproxy-0.4.6/work/libproxy-0.4.6_build/bindings/perl
/src && /usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++  -DPLlibproxy_EXPORTS  
-DNDEBUG -O2 -pipe -march=core2 -frecord-gcc-switches -mssse3 -mcx16 -mmmx 
-msse4 -g -Wimplicit-function-declaration -Wmissing-include-dirs  -fPIC 
-I/var/tmp/portage/net-libs/libproxy-0.4.6/work/libproxy-0.4.6 
-I/usr/lib64/perl5/5.8.8/x86_64-linux/CORE 
-I/var/tmp/portage/net-libs/libproxy-0.4.6/work/libproxy-0.4.6/libproxy   -o 
CMakeFiles/PLlibproxy.dir/Libproxy.c.o -c 
/var/tmp/portage/net-libs/libproxy-0.4.6/work/libproxy-0.4.6_build/bindings/perl
/src/Libproxy.c
cc1plus: warning: command line option "-Wimplicit-function-declaration" is 
valid for C/ObjC but not for C++
cc1plus: warning: command line option "-Wimplicit-function-declaration" is 
valid for C/ObjC but not for C++

This is something which shouldn't be. Our bugreport is located at:
http://bugs.gentoo.org/show_bug.cgi?id=338125

Original issue reported on code.google.com by hilli...@googlemail.com on 1 Oct 2010 at 9:00

Attachments:

• libproxy-0.4.6:20101001-084703.log

[GoogleCodeExporter]

Suggested patch:

Index: bindings/perl/src/CMakeLists.txt
===================================================================
--- bindings/perl/src/CMakeLists.txt    (revision 768)
+++ bindings/perl/src/CMakeLists.txt    (working copy)
@@ -10,9 +10,6 @@

 set(Libproxy_LIB_SRCS Libproxy.c)

-set(CMAKE_C_COMPILER ${CMAKE_CXX_COMPILER})
-set(CMAKE_C_FLAGS ${PERL_CXX_FLAGS} )
-
 set(LIBRARY_OUTPUT_PATH ${CMAKE_BINARY_DIR}/perl/blib/arch/auto/Net)
 add_library(PLlibproxy SHARED ${Libproxy_LIB_SRCS})

--

In first place though we'll have to verify why the compiler has been overridden 
like this to C++.... looks odd. A local test build passed.

Original comment by dominiqu...@gmail.com on 1 Oct 2010 at 10:41

• Changed state: FixProposed

[GoogleCodeExporter]

commited in r773

Original comment by dominiqu...@gmail.com on 12 Oct 2010 at 2:51

• Changed state: Fixed