search

binarycrusader / libproxy

Automatically exported from code.google.com/p/libproxy
GNU Lesser General Public License v2.1
0 stars 0 forks source link

Support for picking a mozilla javascript PAC runner, and support for seamonkey #59

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Configure libproxy with --with-mozjs

What is the expected output? What do you see instead?
An ability to pick a certain mozjs PAC runner (xulrunner-js, firefox-js, 
mozilla-js).
Instead currently the first option is picked that is found on the system where 
compilation is 
done. This is problematic for correctly marking down dependencies in 
distribution packages.

What version of the product are you using? On what operating system?
Version 0.2.3 on Gentoo Linux.

Please provide any additional information below.
I wrote a patch to support seamonkey and picking a certain mozjs provider a 
while ago for 
use in Gentoo Linux. As it has been some time before reporting it here, due to 
not having had 
time to verify the patch on trunk, I decided it's better to report and attach 
the patch as is for 
now, and tend to verifying it against trunk myself later on when there's time, 
if you guys 
haven't gotten to it at that point. Meanwhile hopefully it's helpful for other 
distros, or it could 
maybe be incorporated as-is already after some checks.

Original issue reported on code.google.com by mart.raudsepp@gmail.com on 29 Jul 2009 at 2:39

GoogleCodeExporter commented 9 years ago 
This patch adds the ability to pass a value to --with-mozjs. Either xulrunner, 
firefox, mozilla or seamonkey 
(the latter adds support for seamonkey provided JS).
If a value is provided, that javascript provider is checked for, required, and 
used.
If no value is provided, the behaviour should stay the same as before.
This adds seamonkey as a potential javascript provider if automatic selection 
is done (no argument given 
to --with-mozjs, or with --with-mozjs=auto)

Original comment by mart.raudsepp@gmail.com on 29 Jul 2009 at 2:43

Attachments:

GoogleCodeExporter commented 9 years ago 
Seamonkey as a JS provider has been added a while ago.

Can you please forward port your patch to current trunk?

Original comment by dominiqu...@gmail.com on 3 Aug 2009 at 5:33

GoogleCodeExporter commented 9 years ago 
Mart,

The idea of your fix looks good and we agreed that we want to go ahead with it 
(now
as 0.3 is out we can break all we want again until 0.4).

The idea though neesd some slight adaption. Instead of specifying
--with-mozjs={a,b,c,auto} wel'll need to implement
--with-xulrunner={module|builtin}
--with-seamonkey={module|builtin}
--with-firefox={module|builtin}

The 'issue' is that we will have the option between 'external' and 'internal' 
modules
and the parameter will be reserved for this.

Also, we'd like to just offer the distributions the option to distribute the 
various
pacrunners without hassle.

Original comment by dominiqu...@gmail.com on 17 Aug 2009 at 5:27

GoogleCodeExporter commented 9 years ago 
This patch needs to be updated for trunk which now uses cmake.  Care to help 
out?

Original comment by npmccallum@gmail.com on 22 Jan 2010 at 8:51

GoogleCodeExporter commented 9 years ago

Original comment by npmccallum@gmail.com on 17 Feb 2010 at 2:05

GoogleCodeExporter commented 9 years ago 
Fixed in r600.  See MOZJS_SEARCH_ORDER cache variable.

Original comment by npmccallum@gmail.com on 6 Mar 2010 at 7:13