Warning as error in config_gnome

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Build libproxy 0.4 with -Wall -Werror

What is the expected output? What do you see instead?
The build is failing at:
cc1plus: warnings being treated as errors
modules/config_gnome.cpp: In function 'int popen2(const char*, FILE**,
FILE**, pid_t*)':
modules/config_gnome.cpp:76: error: ignoring return value of 'int
dup(int)', declared with attribute warn_unused_result
modules/config_gnome.cpp:77: error: ignoring return value of 'int
dup(int)', declared with attribute warn_unused_result
make[2]: Leaving directory `/builddir/build/BUILD/libproxy-0.4.0'
make[2]: ***
[libproxy/CMakeFiles/config_gnome.dir/modules/config_gnome.cpp.o] Error 1
make[1]: *** [libproxy/CMakeFiles/config_gnome.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

What version of the product are you using? On what operating system?
libproxy 0.4 Fedora 13

Please provide any additional information below.

This warning usually means return code for the related function need to be
evaluated:
Here is another sample patch for the same kind of error:
http://code.google.com/p/chromium/issues/detail?id=16948

Original issue reported on code.google.com by kwiz...@gmail.com on 14 Mar 2010 at 3:31

[GoogleCodeExporter]

Fixed in r621.

Original comment by npmccallum@gmail.com on 14 Mar 2010 at 7:46

• Changed state: Fixed

[GoogleCodeExporter]

Original comment by nicolas.dufresne@gmail.com on 18 May 2010 at 3:09

• Added labels: Milestone-Release0.4.1