search

binarykitchen / find-remove

recursively finds files by filter options from a start directory onwards and deletes these. useful if you want to clean up a directory in your node.js app.
https://npmjs.org/package/find-remove
61 stars 19 forks source link

Node 16 support #28

Closed dell-mic closed 3 years ago

dell-mic commented 3 years ago

Hi,

thanks a lot for this package.

While upgrading some projects to node 16 (will be the next LTS version) I noticed that this package claims to not be compatible: error find-remove@3.0.1: The engine "node" is incompatible with this module. Expected version "^14.4.0". Got "16.0.0" error Found incompatible module.

I have not yet tested if everything would still run when installed with --ignore-engines. The installation itself went fine, however.

Best, Michael

binarykitchen commented 3 years ago

You are fast mate, being already on node v16.0.0 (while it doesn't attract me yet)

Alright, I've run some tests myself, improved coverage and since there are no breaking changes, only made a minor version bump: v3.1.0 is out to embrace node v15 + v16 both.

Thanks for pushing. Hope all is swell now. Cheers :)

dell-mic commented 3 years ago

And you have been quite fast addressing this! Thank you very much!

Looks like everything ist still working fine with node 16 for me as well.