binarykitchen / videomail-client

A wicked npm package to record videos directly in the browser, wohooo!
https://videomail.io
Creative Commons Zero v1.0 Universal
55 stars 19 forks source link

Add react example code to the README #183

Open IanPhilips opened 3 years ago

IanPhilips commented 3 years ago

Submitting this is a talking point, feel free to suggest another way of adding this documentation.

I had to load using the CDN because of #181.

binarykitchen commented 3 years ago

Thanks for this!

Honestly I am not a fan of using CDN. Understand it's a limitation due to Gatsby being a SSR. That would mean your example is actually for Gatsby itself, not React. Because in a normal client-side React app we wouldn't have this problem.

Submitted a review.

IanPhilips commented 3 years ago

Good point! Thanks for the review, I'll fix those issues.

This is definitely a Gatsby example. I can cook up a react example, would you prefer to have the gatsby example on file somewhere or just a plain react example?

binarykitchen commented 3 years ago

Thanks. Plain React please.