search

binarylogic / authlogic

A simple ruby authentication solution.
http://rdoc.info/projects/binarylogic/authlogic
MIT License
4.34k stars 638 forks source link

Incompatible with Rails 7.1 #768

Closed morgoth closed 9 months ago

morgoth commented 11 months ago

The Rails 7.1 is out, but the authlogic is not compatible with it https://github.com/binarylogic/authlogic/blob/master/authlogic.gemspec#L28-L30

Didn't check if the gem lock is the only blocker.

refs https://github.com/binarylogic/authlogic/pull/767

ansonhoyt commented 11 months ago

@morgoth I think you meant the title to have "Rails 7.1".

cedvw commented 11 months ago

This is trivial and easy to fix issue. PR available. Would be nice to get that merged. Thanks!

msuliq commented 9 months ago

This issue is still valid as of today. I see that the previous PR is failing in github actions, so I did another PR with minimal changes. I can look into failing CI actions if someone with proper privileges would trigger them

msuliq commented 9 months ago

For those who are okay with using a fork until the fix is merged upstream, you can add the gem into your Gemfile as: gem "authlogic", git: "https://github.com/msuliq/authlogic", branch: “bug/compatibility-with-rails-7-1” This will fetch the fork from my personal repo

tiegz commented 9 months ago

authlogic 6.4.3 is now published with the Rails 7.1 fixes.