Open taddgiles opened 15 years ago
This error appeared in a recent update of authlogic_openid. With version 1.0.4, all of my tests pass. With the current version, several things break, including the problem you mention here.
so your tests pass with authlogic_openid 1.0.4? And which version of authlogic are you using?
I was using 2.0.14, but have now upgraded to 2.1.1. Both pass all my tests. When I upgrade authlogic_openid to the current version, I get errors and assertion failures. The errors are the same one you report above: missing user_sessions/create.html.erb template.
same problem here, with lastest version. authlogic 2.1.1 + authlogic-oid 1.0.4 all ok.
yup, confirmed, authlogic 2.0.14 and authlogic-oid 1.0.4 pass for me too.
I posted something to the google group a while back about a commit that was made almost a month ago... You guys might want to check if it's the same issue I was having.
yes this solution fix this problem, thnx sporkd. now remains some problems with auto_register enabled.
Is there any chance of this being fixed and released in the official gem? I cannot modify code as in sporkd's link since I don't have control over gems in my deployment environment (Heroku), but can only reference ones that are in the gem repositories.
Does heroku only let you use the official gem? i.e. can you not build your own? http://gems.github.com
If this is not possible, I would post to the thread up on the google group, as I'm not sure if ben checks these issues very often.
See line 71 of lib/authlogic-oid/session.rb . When using authlogic-oid, it clears out the block:
def save(&block)
block = nil if !openid_identifier.blank?
super(&block)
end
leaving us with no render at all, so the default create template gets loaded.
My fix is to move the render on fail outside the block in the controller, and condition it on the record saving:
render :action => "new" if @user_session.new_record? # workaround for render inside authlogic-oid
bmishkin: Can you post your controller, please ? thx.
The following might be worth a try:
def create @user_session = UserSession.new(params[:user_session]) @user_session.save do |result| if result flash[:notice] = "Successfully logged in." redirect_to root_url end end if !performed? # no render or redirect yet render :action => 'new' end end
authlogic v2.0.13 and authlogic-oid v1.0.4
When I submit an invalid open id to a new session ("goodopenid.com" in my case) I get the following error:
Missing template user_sessions/create.erb in view path app/views
Here's my user_sessions_controller create method (copied from examples)
def create @user_session = UserSession.new(params[:user_session])
We are saving with a block to accomodate for OpenID authentication
end
For some reason its attempting to render "create" rather than rendering "new" with errors.
Incidentally, I see the same problem in the sample app here:
http://authlogicexample.binarylogic.com/
There, when I use "goodopenid.com" I get a crash.
Ideas?