binarylogic / authlogic_openid

Extension of the Authlogic library to add OpenID support.
http://authlogic-oid.rubyforge.org
MIT License
167 stars 44 forks source link

Missing template user_sessions/create.erb in view path app/views #3

Open taddgiles opened 15 years ago

taddgiles commented 15 years ago

authlogic v2.0.13 and authlogic-oid v1.0.4

When I submit an invalid open id to a new session ("goodopenid.com" in my case) I get the following error:

Missing template user_sessions/create.erb in view path app/views

Here's my user_sessions_controller create method (copied from examples)

def create @user_session = UserSession.new(params[:user_session])

We are saving with a block to accomodate for OpenID authentication

# If you are not using OpenID you can save without a block:
#
#   if @user_session.save
#     # ... successful login
#   else
#     # ... unsuccessful login
#   end
@user_session.save do |result|
  if result
    flash[:notice] = "Login successful!"
    redirect_back_or_default root_path
  else
    render :action => :new
  end
end

end

For some reason its attempting to render "create" rather than rendering "new" with errors.

Incidentally, I see the same problem in the sample app here:

http://authlogicexample.binarylogic.com/

There, when I use "goodopenid.com" I get a crash.

Ideas?

Bluejade commented 15 years ago

This error appeared in a recent update of authlogic_openid. With version 1.0.4, all of my tests pass. With the current version, several things break, including the problem you mention here.

taddgiles commented 15 years ago

so your tests pass with authlogic_openid 1.0.4? And which version of authlogic are you using?

Bluejade commented 15 years ago

I was using 2.0.14, but have now upgraded to 2.1.1. Both pass all my tests. When I upgrade authlogic_openid to the current version, I get errors and assertion failures. The errors are the same one you report above: missing user_sessions/create.html.erb template.

dbarison commented 15 years ago

same problem here, with lastest version. authlogic 2.1.1 + authlogic-oid 1.0.4 all ok.

taddgiles commented 15 years ago

yup, confirmed, authlogic 2.0.14 and authlogic-oid 1.0.4 pass for me too.

sporkd commented 15 years ago

I posted something to the google group a while back about a commit that was made almost a month ago... You guys might want to check if it's the same issue I was having.

http://groups.google.com/group/authlogic/browse_thread/thread/fdc8dad50e8cf267/203f774bad6faa46?lnk=gst&q=block#203f774bad6faa46

dbarison commented 15 years ago

yes this solution fix this problem, thnx sporkd. now remains some problems with auto_register enabled.

tfe commented 15 years ago

Is there any chance of this being fixed and released in the official gem? I cannot modify code as in sporkd's link since I don't have control over gems in my deployment environment (Heroku), but can only reference ones that are in the gem repositories.

sporkd commented 15 years ago

Does heroku only let you use the official gem? i.e. can you not build your own? http://gems.github.com

If this is not possible, I would post to the thread up on the google group, as I'm not sure if ben checks these issues very often.

bmishkin commented 15 years ago

See line 71 of lib/authlogic-oid/session.rb . When using authlogic-oid, it clears out the block:

  def save(&block)
    block = nil if !openid_identifier.blank?
    super(&block)
  end

leaving us with no render at all, so the default create template gets loaded.

My fix is to move the render on fail outside the block in the controller, and condition it on the record saving:

render :action => "new" if @user_session.new_record? # workaround for render inside authlogic-oid
davidsf commented 15 years ago

bmishkin: Can you post your controller, please ? thx.

omarkarim commented 15 years ago

The following might be worth a try:

def create @user_session = UserSession.new(params[:user_session]) @user_session.save do |result| if result flash[:notice] = "Successfully logged in." redirect_to root_url end end if !performed? # no render or redirect yet render :action => 'new' end end