binarylogic / searchlogic

Searchlogic provides object based searching, common named scopes, and other useful tools.
http://rdoc.info/projects/binarylogic/searchlogic
MIT License
1.4k stars 133 forks source link

Strange behaviour when combining scopes with OR #140

Open dlupu opened 13 years ago

dlupu commented 13 years ago

Hello,

I'm currently implementing a search form in our users database. I would like to search by id , by login or by email.

Naturally, I think that the best aproach is to combine scopes and simplify the form. So I added a text_field for :id_or_login_or_email_like.

Everything works fine when I type a number in the text-field.

However, when I type a word and press search, the value i typed is losed and replaced with a 0 (zero) and the search result returns all users that have 0 in the ID, name or login.

Any ideas on how to fix this? I'm using Rails 2.3.2 and SearchLogic 2.4.27. Thanks!

dlupu commented 13 years ago

Got an answer on StackOverFlow. I'm copy/paste it here, hoping someone will clear the mistery:

"I think this is because your scope is making a comparison against an integer when comparing to id, which causes your string to be converted to 0. Try using .dup to ensure that the passed attribute to the scope is not changed."

Source: http://stackoverflow.com/questions/4857721/searchlogic-strange-behaviour-when-combining-scopes-with-or

dlupu commented 13 years ago

Never mind, I found a workaround: when combining scopes with OR, put the scope related to integer values at the end.

So instead of :id_or_login_or_email_like use login_or_email_or_id_like. This seems like a bug to me.