Fixes issues with Ruby 1.8.7, etc...

binarylogic / searchlogic

Searchlogic provides object based searching, common named scopes, and other useful tools.

http://rdoc.info/projects/binarylogic/searchlogic

MIT License

1.4k stars 133 forks source link

Fixes issues with Ruby 1.8.7, etc... #156

Closed johndouthat closed 12 years ago

johndouthat commented 12 years ago

Thank you so much for Searchlogic. It's really great. I'm using it in several apps.

Fixes an issue with Searchlogic::ActiveRecord::Scope#scopes
Fixes a Ruby 1.8.7 compatibility issue in Searchlogic::Search::Conditions#compatct_conditions
Adds Appraisal support for testing multiple versions of ActiveRecord at once
Backed up AR support from 2.3.11 to 2.3.9. Now the specs pass with ActiveRecord 2.3.9 - 2.3.14 on Ruby 1.9.3-p125, 1.9.2-p318, and 1.8.7-p358
Adds some specs for coverage
fixes documentation and problem in alias_scope
Mucks with the gemfile a little bit. Sorry about that!

I'm going to try to work on Rails 3.2 compatibility in the near future, but for now I hope these changes help.

oddlyzen commented 12 years ago

@johndouthat Thanks for the work you put into this! We're actually currently working on a fork for Rails 3 compatibility. If you'd like to help out (and get a first look), ping me and we will keep you in the loop during the upgrade process.

johndouthat commented 12 years ago

Hi Mark,

Yeah, I'd love to help out and take a look.

Thank You, John Douthat

Sent from my iPhone

On Apr 24, 2012, at 2:04 PM, Mark Coatesreply@reply.github.com wrote:

@johndouthat Thanks for the work you put into this! We're actually currently working on a fork for Rails 3 compatibility. If you'd like to help out (and get a first look), ping me and we will keep you in the loop during the upgrade process.

Reply to this email directly or view it on GitHub: https://github.com/binarylogic/searchlogic/pull/156#issuecomment-5314010