Properly implement to_hash

binarylogic / settingslogic

A simple and straightforward settings solution that uses an ERB enabled YAML file and a singleton design pattern.

http://rdoc.info/projects/binarylogic/settingslogic

MIT License

1.4k stars 186 forks source link

Properly implement to_hash #44

Closed cmer closed 11 years ago

cmer commented 11 years ago

Without this, calling to_hash always returned a SettingsLogic instance, which caused problems when calling methods such as #symbolize_keys on the resulting object.

PikachuEXE commented 11 years ago

:thumbsup:

PikachuEXE commented 11 years ago

There is also another pull request also for #to_hash: #25 Take a look

bekkou68 commented 11 years ago

cool! clear implementation :)

neersighted commented 11 years ago

:+1:

PikachuEXE commented 11 years ago

But still not pulled...

cmer commented 11 years ago

Can this please be merged already? I believe my pull request is clean, well tested and fixes a weird oddity. Seems pretty straight forward to me. Thanks!

PikachuEXE commented 11 years ago

The members of the organization seem not quite active... At least on this project

bekkou68 commented 11 years ago

umm, what's going on. the last pull request merged is 2 months ago, so this request may be already seen by authers. https://github.com/binarylogic/settingslogic/commit/6be535aa74f68f35c88109b32fd2038e9819721d

something problem? or what? please comment here...

cmer commented 11 years ago

Thanks!