search

binarymatt / pyres

a resque clone in python
http://github.com/binarydud/pyres
MIT License
955 stars 130 forks source link

ability to re queue failed items #15

Closed binarymatt closed 14 years ago

binarymatt commented 14 years ago

Sometimes a failed item needs to be re-queued because the issue was a path problem with the worker.

mjrusso commented 14 years ago

Is the plan to enable both a "requeue" method that can be called programmatically, and a supporting control in the web interface?

binarymatt commented 14 years ago

that is it exactly.

If you look at the failure module, there's already a requeue method for programatically putting failed items back on the queue. The web interface is next.

binarymatt commented 14 years ago

also see issue binarydud/pyres#33

aezell commented 14 years ago

Working on this now. Commentary is happening on the mailing list.

aezell commented 14 years ago

I've created a branch with working code to requeue and delete jobs from the failure queue. I'd love some feedback.

The branch: http://github.com/aezell/pyres/tree/requeue_jobs

Edit: Fixed link. Thanks mjrusso.

mjrusso commented 14 years ago

I believe that you linked to the wrong branch ;-)

Try this one: http://github.com/aezell/pyres/tree/requeue_jobs

I think it looks great. Some feedback that I shared on the mailing list would be to use a list_range method like the following:

https://gist.github.com/341182/db9ed4013f147cebc3b9a1aebc156132cc7e8599

binarymatt commented 14 years ago

aezell's branch has been merged into master and will be pushed out in the 0.8 release coming soon