search

binarymatt / pyres

a resque clone in python
http://github.com/binarydud/pyres
MIT License
955 stars 130 forks source link

Miscellaneous fixes #51

Closed chawco closed 13 years ago

chawco commented 13 years ago

Contains some fixes for:

setup.py (entry points are defined using a deprecated method, thanks to rspivak for this fix) refactored unit tests for failure backends, including passing unit tests for the MultipleBackend

binarymatt commented 13 years ago

i'll go ahead and pull in the changes to the failure backend and tests tonight. However, there are a couple of things in the 6ebf8b6 commit that I have questions about.

First, was it intentional to add the copyright header to the setup.py file? Second, can you explain what you mean about the entry points using a deprecated method. As far as I can tell, the scripts attribute in the setup method is still completely valid.

chawco commented 13 years ago

Sorry, that was accidental. I'll go ahead and remove it.

As far as the entry_points is concerned, the old scripts= method is still valid for setuptools, as it is provided by distutils. The problem comes with newer systems, such as pip, paster, buildout, etc. All the newer systems depend on entry_points rather than scripts, and this is now the de-facto way to distribute python scripts. Additionally this method will auto generate appropriate scripts for the target system, as well as target Python installation (say, if you're using something like virtualenv). Thanks again to rspivak for clarification.

Also see http://peak.telecommunity.com/DevCenter/setuptools#automatic-script-creation for further clarification.

chawco commented 13 years ago

Here is the relevant commit: https://github.com/chawco/pyres/commit/0aac250829a3762290d17a4461362e43348c6b42

chawco commented 13 years ago

A couple of quick fixes from rspivak and mjrusso, so that we can run under 2.7.

mjrusso commented 13 years ago

Confirmed that pyres_worker now works on Python 2.7 with chawco/pyres@1cf7a1d8251ed5247dcbb81641cbea0929a5a87b.

binarymatt commented 13 years ago

This is merged in, thanks a bunch. Hopefully I can knock out some of the tickets for the 1.0 release and get it pushed out this week.