search

binarymatt / pyres

a resque clone in python
http://github.com/binarydud/pyres
MIT License
955 stars 130 forks source link

add support for GELF logging to pyres via graypy #79

Closed joeshaw closed 12 years ago

joeshaw commented 13 years ago

It is another special value passed in through the -f option, in the form: "gelf:hostname:port"

I'm not sure if you want to add another logging hack to the code. I'm beginning to think that maybe the logging code should be ripped out and replaced with logging.config.fileConfig() usage and include the current configuration and some other examples in a file included w/ pyres.

binarymatt commented 13 years ago

i'm hesitant to include another dependency for pyres, especially one that's conditional. However, i'd definitely be down for setting up a more robust logging configuration with some sensible defaults.

joeshaw commented 13 years ago

Make sense. I can keep this local to my fork and when I get a chance I'll look into making it work with logging.config.

joeshaw commented 12 years ago

I had some trouble getting this to work, namely with the khan/minions -- it seems like python's built-in logging.config does not fit this model very well. For the moment I've kept my GELF hack, but there's probably a good middle ground still to be found,

joeshaw commented 12 years ago

Closing this; I've stopped using GELF and won't spend any more time on this.