search

binarymatt / redshift_sqlalchemy

Amazon Redshift SQLAlchemy Dialect
MIT License
48 stars 21 forks source link

One way to fix for sqlalchemy 9.0 #8

Closed mcginleyr1 closed 10 years ago

mcginleyr1 commented 10 years ago

I honestly don't know much at all about the internals of sqlalchemy and the dialects. However this is an attempt at fixes #7 . Really it pull the logic out of PGDialect and BaseDialect and uses them in the initialize so we don't break the encapsulation to much. I also haven't played around with wether or not all of that code is needed.

binarymatt commented 10 years ago

Thanks, i will take a look at this tonight.

binarymatt commented 10 years ago

i'm going to leave this open for now, but it looks like this will be fixed in the upstream dialect for 0.9.3: https://bitbucket.org/zzzeek/sqlalchemy/commits/28229a35e0231e770679ce48436f

mcginleyr1 commented 10 years ago

Ah nice. Feel free to close when it is :)

binarymatt commented 10 years ago

looks like 0.9.3 and 0.8.5 were released today: http://www.sqlalchemy.org/blog/#sqlalchemy-0.9.3-released