binarynonsense / comic-book-reader

ACBR - A comic book reader and converter for CBZ, CBR, CB7, EPUB and PDF files (Windows & Linux)
BSD 2-Clause "Simplified" License
184 stars 8 forks source link

Update german #113

Closed trzyglow closed 6 months ago

trzyglow commented 6 months ago

sidenote: I think "Text direction" would be easier to understand than "Language direction"

binarynonsense commented 6 months ago

Thanks!!

binarynonsense commented 6 months ago

"Language direction" in this case is the direction the language is read, for example Arabic is right to left and English left to right. I feel like "text direction" doesn't convey that in this context, at least in English or Spanish, maybe in German it does.

Edit: I probably should add a [NOTE TO TRANSLATORS] explaining the context.

binarynonsense commented 6 months ago

If you are curious, this relates to me trying to add support for rtl languages after another contributor added Arabic localization. You can read about how it's going here: https://github.com/binarynonsense/comic-book-reader/pull/110

trzyglow commented 6 months ago

"Text Orientation" might be the correct term (at least it is in regards to 'top to bottom' text like in some east asian languages)

binarynonsense commented 6 months ago

Maybe I didn't explain it too well, what I mean is this text will be an option in the preferences for toolbar, named direction, where you will choose between "Language Direction", "Right to Left" and "Left to Right". With Language Direction implying that instead of chosing one you let the app use the direction from the current language... maybe it'd be better to name it "Use Language Direction", or "Same as Language Direction"? I feel like text orientation doesn't convey it either.

trzyglow commented 6 months ago

"Writing System" is probably the most accurate since it implies both alphabetical differences and differences in formatting. short definition to clarify:

A writing system comprises a particular set of symbols, called a script, as well as the rules by which the script represents a particular language. Writing systems can generally be classified according to how symbols function according to these rules, with the most common types being alphabets, syllabaries, and logographies.

binarynonsense commented 6 months ago

In UI design and css they use the term direction (and it limits itself only to left to right or right to left), and I would like to make clear that with this option the value is inferred from the chosen Language.

binarynonsense commented 6 months ago

This is specific to the horizontal direction in which the UI, in this case the toolbar, is set. For ltr "mode" it's like it has been so far, but in "rtl" most things are mirrored. what I'm trying to convey is that the horizontal layout, its direction property, is set to ltr or rtl either by setting it explicitly or inferring it from the selected language, which can of ltr (English) or rtl (Arabic) direction. This is all a bit new to me, so I'm figuring things out as I go :)

binarynonsense commented 6 months ago

Maybe "Infer from Selected Language"?

Edit: I think I like this one the most so far

trzyglow commented 6 months ago

i think so, too; most other things i could find are even more vague Edit: or absurdly long

binarynonsense commented 6 months ago

Yeah, I have a lot of trouble some times trying to find something sort but meaningful :) I'll change it to "Infer from Selected Language" then. Thanks for the feedback!!