search

binarynonsense / comic-book-reader

ACBR - A comic book reader and converter for CBZ, CBR, CB7, EPUB and PDF files (Windows & Linux)
BSD 2-Clause "Simplified" License
184 stars 8 forks source link

Update de.json #99

Closed trzyglow closed 8 months ago

trzyglow commented 8 months ago

Since the terminology in context of the german language is the same as the prior entries, i just added additional context to the entry for the gamepad related mapping

binarynonsense commented 8 months ago

Perfect, thanks!

binarynonsense commented 8 months ago

Just noticed that the warning messages "tool-pre-navkeys-modal-resetall-message" and "tool-pre-navbuttons-modal-resetall-message" are exactly the same. Could 'Tastenbelegung' be replaced with 'Gamepad Tastenbelegung', like in the section title, in "tool-pre-navbuttons-modal-resetall-message" to be more explicit about which mappings are going to be reset?

I haven't started trying adding the Button Mapping options yet but, although under a different section title, they will be right below the Key Mapping ones in the "User Interface" section of the preferences, not in separated tabs, so a user may be confused if both reset buttons, given than in German they are referred as keys in both cases, ask if you want to reset the key assignments (they may think it will reset all the key assignments listed in the UI tab, not just the ones corresponding to that section).

trzyglow commented 8 months ago

Could 'Tastenbelegung' be replaced with 'Gamepad Tastenbelegung', like in the section title, in "tool-pre-navbuttons-modal-resetall-message" to be more explicit about which mappings are going to be reset?

yes

added it in #100