Resolve #406 - exit_binding_identifier now handles lazy functions

binast / binjs-ref

Reference implementation for the JavaScript Binary AST format

https://binast.github.io/binjs-ref/binjs/index.html

Other

433 stars 38 forks source link

Resolve #406 - exit_binding_identifier now handles lazy functions #407

Closed Yoric closed 5 years ago

Yoric commented 5 years ago

exit_binding_identifier contains a hard-coded list of nodes that represent functions. This is hardly ideal (perhaps we should somehow put this in the webidl?) and at some point, we failed to update this list, causing the bug.

RReverser commented 5 years ago

Seems fine by me, but I'll better leave it to you and @arai-a :)

RReverser commented 5 years ago

@Yoric Although, could you maybe change or re-enable tests responsible for lazification as part of this?