search

binast / binjs-ref

Reference implementation for the JavaScript Binary AST format
https://binast.github.io/binjs-ref/binjs/index.html
Other
433 stars 38 forks source link

Replace set_extension calls #408

Closed xtuc closed 5 years ago

xtuc commented 5 years ago

create-react-app generate files with [name].[hash].js format. Rust's Path considers that [hash].js is the extension, set_extension loses the hash.

xtuc commented 5 years ago

I suspect that .{grammar,strings,tree} files are still using set_extension.

RReverser commented 5 years ago

@xtuc Possible. I guess let's fix all of them together.

xtuc commented 5 years ago

I just tested it, it's working as expected.

xtuc commented 5 years ago

@RReverser could you please another look at this?