search

binast / binjs-ref

Reference implementation for the JavaScript Binary AST format
https://binast.github.io/binjs-ref/binjs/index.html
Other
433 stars 38 forks source link

Update itertools. #413

Closed emilio closed 5 years ago

emilio commented 5 years ago

This allows me to update it in Gecko without duplicating the dependency.

emilio commented 5 years ago

Yeah, a new version would be appreciated! :)

Yoric commented 5 years ago

@emilio it doesn't seem to pass tests, can you check?

emilio commented 5 years ago

I had missed a --all in my cargo test command. Should be good now :)

Yoric commented 5 years ago

Thanks :)

Yoric commented 5 years ago

New version released.

Yoric commented 5 years ago

@emilio I'm updating SpiderMonkey to use the latest version but ./mach rust vendor still claims that 0.7.x is used somewhere.

emilio commented 5 years ago

Yes, it's used in the style system, I can take care to update it and you can review, or vice versa I guess :)

emilio commented 5 years ago

As far as I can tell, updating itertools in the style crate should require no code changes at all, so I'm happy to rubber-stamp the version increment.